images: Remove unused install-builder-deps.sh script #40870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienPatte
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Good find 👍 sorry @msune for having referred you to this file 😅
|
/test |
sayboras
approved these changes
Aug 1, 2025
|
(can't officially approve but..) ACK! |
michi-covalent
approved these changes
Aug 1, 2025
|
Disabling auto-merge - This PR conflicts with #40874. Let's merge that other one first to unblock Marc's PR: here, we've carried this unused file along for five years, we can wait a bit longer before it's removed. |
glrf
approved these changes
Aug 4, 2025
It looks like script install-builder-deps.sh has never been used for generating builder images. Ever since it was introduced in commit 7724ceb ("build: New builder image supporting cross-compilation"), it's never been called anywhere in the repository. Remove it to avoid confusion as in cilium#40838. Link: cilium#40294 (comment) Signed-off-by: Quentin Monnet <qmo@qmon.net>
efefecf to
65a5cbe
Compare
|
Rebasing now that conflicting PR is merged |
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
|
/test |
christarazi
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like script
install-builder-deps.shhas never been used for generating builder images. Ever since it was introduced in commit 7724ceb, it's never been called anywhere in the repository. Let's try to remove it and see if everything still builds as expected.Cc @msune