Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Aug 1, 2025

Once this PR is merged, a GitHub action will update the labels of these PRs:

 40848

[ upstream commit 7d22d84 ]

[ backporter's notes: extended the same changes to the parsing of
  Endpoint and EndpointSliceV1Beta1 types, whose support had already
  been removed in the main branch. ]

The blamed commit reworked the storage of port information as part of
the k8s.Backends structure, with the goal of reducing allocations.
However, unnamed ports are handled differently, which down the line
broke the propagation of services via clustermesh, when associated
with unnamed ports, as incorrectly ignored.

Let's get this fixed by uniforming the handling, and adding appropriate
filtering to remove the unnamed port entry where appropriate, to
preserve the existing behavior. Additionally, let's extend the service
synchronization script test, to prevent future regressions.

Fixes: 12ae78b ("k8s,loadbalancer: Optimize 'k8s.Backend.Ports' to reduce allocations")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/backports This PR provides functionality previously merged into master. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. labels Aug 1, 2025
@giorio94 giorio94 requested a review from joamaki August 1, 2025 07:32
@giorio94
Copy link
Member Author

giorio94 commented Aug 1, 2025

/test

@giorio94 giorio94 marked this pull request as ready for review August 1, 2025 07:32
@giorio94 giorio94 requested a review from a team as a code owner August 1, 2025 07:32
@giorio94 giorio94 added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Aug 1, 2025
@giorio94 giorio94 enabled auto-merge August 1, 2025 12:15
@giorio94 giorio94 added this pull request to the merge queue Aug 5, 2025
Merged via the queue into v1.18 with commit 2cd9057 Aug 5, 2025
318 checks passed
@giorio94 giorio94 deleted the pr/v1.18-backport-2025-08-01-09-24 branch August 5, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants