Add TESTOWNERS file #40864
Merged
Add TESTOWNERS file #40864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream commit dda3976 ("Fix code owner attribution for test failures on stable branches") recently updated the tree to detect and use the TESTOWNERS file to determine ownership for test failures on stable branches. While the backport for this is pending, the TESTOWNERS file is not yet prepared on that branch. This commit does exactly that. This introduces the TESTOWNERS file to be the same as the CODEOWNERS file prior to the v1.18 branch point, which is to say at commit cdf8de6 ("CODEOWNERS: move pkg/logging to sig-agent"). Signed-off-by: Joe Stringer <joe@cilium.io>
youngnick
approved these changes
Aug 1, 2025
|
I suppose that file additions/removals on stable branches is rare enough that we won't need to update this file, and don't need any sort of sanity check workflow like we have for CODEOWNERS? |
|
Yeah especially since the impact will be limited to test cases. I don't expect that to be much of an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream commit dda3976 ("Fix code owner attribution for test
failures on stable branches") recently updated the tree to detect and
use the TESTOWNERS file to determine ownership for test failures on
stable branches. While the backport for this is pending, the TESTOWNERS
file is not yet prepared on that branch. This commit does exactly that.
This introduces the TESTOWNERS file to be the same as the CODEOWNERS
file prior to the v1.18 branch point, which is to say at commit
cdf8de6 ("CODEOWNERS: move pkg/logging to sig-agent").
In conjunction with #40847, this should make the v1.18 branch behave correctly
with respect to #40583.