Skip to content

multicast: do not assign to nil node config map #40859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

multicast: do not assign to nil node config map #40859

merged 1 commit into from
Aug 6, 2025
+1 −1

Conversation

ldelossa
Copy link
Contributor

@ldelossa ldelossa commented Aug 1, 2025 •
edited
Loading

See commit message for details

Fixes: #40830

multicast: fix nil assignment to node configuration cell.Out map

@ldelossa ldelossa requested a review from a team as a code owner August 1, 2025 00:53
@ldelossa ldelossa requested a review from gentoo-root August 1, 2025 00:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 1, 2025
@ldelossa ldelossa added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Aug 1, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 1, 2025
@ldelossa
Copy link
Contributor Author

ldelossa commented Aug 1, 2025

/test

@ldelossa ldelossa force-pushed the ldelossa/fix-multicast branch from 3c9708a to d44293e Compare August 1, 2025 01:10
@ldelossa ldelossa changed the title multicast: do assign to nil node config map multicast: do not assign to nil node config map Aug 1, 2025
@ldelossa
Copy link
Contributor Author

ldelossa commented Aug 1, 2025

/test

@ldelossa
multicast: do not assign to nil node config map
960b782 
The following commit removed the unused node config definition
`MCAST_GROUP_OUTER_V4_MAP`.

commit cce6a96
Author: Timo Beckers <timo@isovalent.com>
Date:   Thu Feb 6 15:42:49 2025 +0100

    multicast: remove unused MCAST_GROUP_OUTER_V4_MAP node define

However, the actual NodeDefines map was not initialized.

Ensure the defines.Map is initialized when enabling multicast.

Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
@ldelossa ldelossa force-pushed the ldelossa/fix-multicast branch from d44293e to 960b782 Compare August 1, 2025 13:32
@ldelossa
Copy link
Contributor Author

ldelossa commented Aug 1, 2025

/test

@ldelossa ldelossa enabled auto-merge August 1, 2025 14:21
@ldelossa ldelossa added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 90725f7 Aug 6, 2025
306 of 307 checks passed
@ldelossa ldelossa deleted the ldelossa/fix-multicast branch August 6, 2025 17:34
@julianwiedmann julianwiedmann added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

@gentoo-root gentoo-root Awaiting requested review from gentoo-root gentoo-root is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to upgrade to cilium 1.18 when multicast group is enabled
3 participants
@ldelossa @harsimran-pabla @julianwiedmann