eni: improve logging and speed up ipam reconciliation in case of node scale-downs #40852
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
IPAM NodeManager keeps track of all nodes within cluster and periodically tries to Resync all CiliumNodes. However, list of nodes might become stale (for example due to scale-down) during resync. As a result, log message ""Unable to update CiliumNode status" error="ciliumnodes.cilium.io Node not found" might be observed in Cilium Operator logs as it tries to update non-existintent CiliumNode. Additionally, it was performing unnecessary k8s API calls, potentially slowing down reconcilation. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Caller of ResyncInterfacesAndIPs already captures error and logs it in pkg/ipam/node.go Example logs before this change: level=warning msg="Instance not found [...]" instanceID nodeName level=warning msg="Instance not found [...]" error="unable to retrieve ENIs" instanceID nodeName for the same node. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
018f617 to
31fed7b
Compare
|
/test |
liyihuang
approved these changes
Aug 1, 2025
aanm
approved these changes
Aug 4, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(description in commits)