clustermesh: fix propagation of services with unnamed ports #40848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blamed commit reworked the storage of port information as part of the k8s.Backends structure, with the goal of reducing allocations. However, unnamed ports are handled differently, which down the line broke the propagation of services via clustermesh, when associated with unnamed ports, as incorrectly ignored. Let's get this fixed by uniforming the handling, and adding appropriate filtering to remove the unnamed port entry where appropriate, to preserve the existing behavior. Additionally, let's extend the service synchronization script test, to prevent future regressions. Fixes: 12ae78b ("k8s,loadbalancer: Optimize 'k8s.Backend.Ports' to reduce allocations") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
joamaki
approved these changes
Jul 31, 2025
tklauser
approved these changes
Jul 31, 2025
|
/test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blamed commit reworked the storage of port information as part of the k8s.Backends structure, with the goal of reducing allocations. However, unnamed ports are handled differently, which down the line broke the propagation of services via clustermesh, when associated with unnamed ports, as incorrectly ignored.
Let's get this fixed by uniforming the handling, and adding appropriate filtering to remove the unnamed port entry where appropriate, to preserve the existing behavior. Additionally, let's extend the service synchronization script test, to prevent future regressions.
Fixes: 12ae78b ("k8s,loadbalancer: Optimize 'k8s.Backend.Ports' to reduce allocations")