daemon: conditionally disable headless service watch #40844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
4ee8020 to
4f501f1
Compare
|
/test |
4f501f1 to
f55c550
Compare
f55c550 to
004a38b
Compare
|
/test |
004a38b to
d8b4063
Compare
|
/test |
|
/ci-clustermesh |
|
This PR contains one of solutions discussed in: #40763, I am happy to discuss alternative approaches |
|
cc @youngnick |
joamaki
requested changes
Aug 6, 2025
joamaki
reviewed
Aug 6, 2025
joamaki
reviewed
Aug 6, 2025
|
/ci-clustermesh |
|
/ci-e2e-upgrade |
|
/ci-ginkgo |
auto-merge was automatically disabled
August 26, 2025 10:48
Head branch was pushed to by a user without write access
26a9de8 to
50e3432
Compare
|
/test |
|
/ci-gateway-api |
|
/ci-e2e-upgrade |
marseel
approved these changes
Aug 27, 2025
|
cc @cilium/envoy for review, I think Jarno is OOO |
Previously, daemon watched headless services and headless services endpoint slices uncodnitially. This meant that even if features relying on headless services watch such as Gateway API and Ingress were not used the watch was created. This caused a increased load on apisever in clusters making use of headless services. This patch disables the headless service watch when feature relying on it (Gateway API, Ingress) are not enabled. Fixes: cilium#40763 Signed-off-by: Maciej Moscicki <mmoscicki@google.com>
auto-merge was automatically disabled
August 29, 2025 08:41
Head branch was pushed to by a user without write access
50e3432 to
e425529
Compare
|
/test |
|
/ci-gateway-api |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, daemon watched headless services and headless services endpoint slices uncodnitially. This meant that even if features relying on headless services watch such as Gateway API and Ingress were not used the watch was created. This caused a increased load on apisever in clusters making use of headless services.
This patch disables the headless service watch when feature relying on it (Gateway API, Ingress) are not enabled.
Tests for the change were copied from the version prior to #28440.
Fixes: #40763
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.