Do not return an error on CNI DEL if namespace no longer exist #40843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @squeed @joestringer |
marseel
reviewed
Jul 31, 2025
If the network namespace does not exist during the CNI DEL command, it is not possible for the interface exist inside the namespace. However, this should not happen in common situations so we log the problem despite not erroring to avoid unnecesary retries from the kubelet. Change-Id: I355fb3ea0a1bfb5662792345675cfb3e8f7962b2 Signed-off-by: Antonio Ojea <aojea@google.com>
joestringer
approved these changes
Aug 1, 2025
|
/test |
marseel
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing on CNI Del can cause multiple issues and depends on the special logic on the container runtime, so it is not consistent across implementations like containerd or crio.
If the network namespace of a Pod no longer exist, CNI DEL can not fail because there is nothing else to do for the CNI.
If it fails can cause different issues, make the Kubelet or the runtime keep retrying the deletion or impact plugins on the CNI chain.