Skip to content

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jul 26, 2025

Add initial metrics about ServiceExport and ServiceImport. This focuses on number of object created and status condition so that users may create monitoring on ServiceExport conflict for instance and when we would have ServiceImport status conditions we will be able to add metrics for those too.

It is based on similar name as kube-state-metrics, see: https://github.com/kubernetes/kube-state-metrics/blob/main/docs/metrics/workload/deployment-metrics.md

clustermesh: add prometheus metrics about local ServiceExport and ServiceImport

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 26, 2025
@MrFreezeex MrFreezeex added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 26, 2025
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from a2626dc to 54c4a6a Compare July 26, 2025 16:33
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch 2 times, most recently from e455317 to 144ae9f Compare July 27, 2025 08:20
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex marked this pull request as ready for review July 27, 2025 10:40
@MrFreezeex MrFreezeex requested a review from a team as a code owner July 27, 2025 10:40
@MrFreezeex MrFreezeex requested a review from giorio94 July 27, 2025 10:40
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of initial comments inline.

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 144ae9f to c4c12b4 Compare July 28, 2025 14:36
@MrFreezeex MrFreezeex requested a review from a team as a code owner July 28, 2025 14:36
@MrFreezeex MrFreezeex requested a review from HadrienPatte July 28, 2025 14:36
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from c4c12b4 to aa3ff91 Compare July 28, 2025 14:43
@MrFreezeex MrFreezeex requested review from a team as code owners July 28, 2025 14:43
@MrFreezeex MrFreezeex requested review from fristonio and qmonnet July 28, 2025 14:43
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from aa3ff91 to 76e6617 Compare July 28, 2025 14:45
Copy link
Member

@HadrienPatte HadrienPatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor LGTM 👍

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch 3 times, most recently from fc42be9 to 6df5620 Compare July 29, 2025 10:01
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 6df5620 to 9eb332f Compare July 29, 2025 15:58
@giorio94 giorio94 requested a review from fristonio August 1, 2025 07:42
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 4dd9c9e to 2dfc118 Compare August 1, 2025 19:25
@MrFreezeex MrFreezeex requested a review from a team as a code owner August 1, 2025 19:25
@MrFreezeex MrFreezeex requested a review from aditighag August 1, 2025 19:25
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 2dfc118 to 3418743 Compare August 1, 2025 19:38
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@joestringer joestringer removed the request for review from aditighag August 1, 2025 20:06
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 3418743 to 8dcab28 Compare August 1, 2025 20:12
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch 2 times, most recently from 0f5b4da to d1e3436 Compare August 1, 2025 20:20
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from d1e3436 to 4f06fb1 Compare August 1, 2025 21:05
@MrFreezeex
Copy link
Member Author

/test

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time I think we got the right balance with CODEOWNERS, thanks 🙏

@joestringer joestringer enabled auto-merge August 1, 2025 21:17
Add initial metrics about ServiceExport and ServiceImport. This focuses
on number of object created and status condition so that users may
create monitoring on ServiceExport conflict for instance and when
ServiceImport status conditions we will be available to add metrics too.

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/svcexport-metrics branch from 4f06fb1 to daab79e Compare August 1, 2025 23:57
@MrFreezeex
Copy link
Member Author

(rebased for the CI)

@MrFreezeex
Copy link
Member Author

/test

@joestringer joestringer added this pull request to the merge queue Aug 3, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 3, 2025
Merged via the queue into cilium:main with commit 3254195 Aug 3, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants