-
Notifications
You must be signed in to change notification settings - Fork 3.4k
clustermesh: add MCS-API prometheus metrics #40736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clustermesh: add MCS-API prometheus metrics #40736
Conversation
/test |
a2626dc
to
54c4a6a
Compare
/test |
e455317
to
144ae9f
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of initial comments inline.
144ae9f
to
c4c12b4
Compare
c4c12b4
to
aa3ff91
Compare
aa3ff91
to
76e6617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor LGTM 👍
fc42be9
to
6df5620
Compare
6df5620
to
9eb332f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
/test |
4dd9c9e
to
2dfc118
Compare
2dfc118
to
3418743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏
3418743
to
8dcab28
Compare
/test |
0f5b4da
to
d1e3436
Compare
/test |
d1e3436
to
4f06fb1
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time I think we got the right balance with CODEOWNERS, thanks 🙏
Add initial metrics about ServiceExport and ServiceImport. This focuses on number of object created and status condition so that users may create monitoring on ServiceExport conflict for instance and when ServiceImport status conditions we will be available to add metrics too. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
4f06fb1
to
daab79e
Compare
(rebased for the CI) |
/test |
Add initial metrics about ServiceExport and ServiceImport. This focuses on number of object created and status condition so that users may create monitoring on ServiceExport conflict for instance and when we would have ServiceImport status conditions we will be able to add metrics for those too.
It is based on similar name as kube-state-metrics, see: https://github.com/kubernetes/kube-state-metrics/blob/main/docs/metrics/workload/deployment-metrics.md