cec: introduce annotation to control use-original-source-address #40707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cilium@b6bcc0c0e2a introduced the label `cilium.io/use-original-source-address` on the CRD `CiliumEnvoyConfig` - with the intent to have fine-grained control of whether Cilium Proxy should use the original source address. Using a K8s label isn't consistent with the fact that all other aspects of a CEC are configured via K8s annotations. From the description of the commit it looks like the intention was to add an annotation instead of the label in the first place. Therefore, this commit introduces a new annotation `cec.cilium.io/use-original-source-address` and deprecates the label. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit changes the Cilium Ingress API & Gateway API reconcilers to use the new annotation `cec.cilium.io/use-original-source-address` instead of the label to configure the `CiliumEnvoyConfig`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
db9e453 to
22b6ad8
Compare
|
/test |
youngnick
reviewed
Jul 27, 2025
jrajahalme
approved these changes
Jul 28, 2025
youngnick
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cec: introduce annotation to control useoriginalsourceaddress
Commit b6bcc0c0e2a introduced the label
cilium.io/use-original-source-addresson the CRDCiliumEnvoyConfig- with theintent to have fine-grained control of whether Cilium Proxy should use
the original source address.
Using a K8s label isn't consistent with the fact that all other aspects of a
CEC are configured via K8s annotations. From the description of the commit
it looks like the intention was to add an annotation instead of the label
in the first place.
Therefore, this commit introduces a new annotation
cec.cilium.io/use-original-source-addressand deprecates the label.