Skip to content

ces: refactor and clean up #40789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

ces: refactor and clean up #40789

merged 3 commits into from
Aug 1, 2025

Conversation

jshr-w
Copy link
Contributor

@jshr-w jshr-w commented Jul 29, 2025

  • Replace usage of map[T]struct{} with sets.Set
  • Remove unused CES manager interface (since Identity mode has been removed)
  • Refactor ceptocesmap to simplify local state

Breaking out some commits from original PR #38388 for convenience :)

ces: refactor and clean up

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 29, 2025
@jshr-w jshr-w force-pushed the jshr/refactorces branch from 2fc4d64 to 60fee3c Compare July 29, 2025 22:16
@jshr-w
Copy link
Contributor Author

jshr-w commented Jul 29, 2025

/test

@jshr-w jshr-w marked this pull request as ready for review July 29, 2025 23:35
@jshr-w jshr-w requested a review from a team as a code owner July 29, 2025 23:35
@jshr-w jshr-w requested a review from thorn3r July 29, 2025 23:35
@jshr-w
Copy link
Contributor Author

jshr-w commented Jul 29, 2025

cc @giorio94 who was reviewing my original PR :)

giorio94
giorio94 approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. feature/ces Impacts the Cilium Endpoint Slice logic. labels Jul 30, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 30, 2025
thorn3r
thorn3r approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@jshr-w jshr-w force-pushed the jshr/refactorces branch from 60fee3c to f921876 Compare July 31, 2025 16:01
jshr-w added 3 commits July 31, 2025 09:04
@jshr-w
CES: use sets.Set instead of map[T]struct{}
670269d 
Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w
CES: remove leftover CES manager interface
d9a7740 
Previously, there were two CES manager types (FCFS & Identity-based)
that implemented the operations interface. The identity-based manager
has been removed, so clean-up the leftover unnecessary interface.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w
CES: refactor ceptocesmap mappings
057a560 
Refactor maps for CES->CEPs and CES->ns into a single map. This change
is intended to reduce complexity in the local state mappings, and is
made in preparation for adding more mappings and logic in future commits
that will create CES directly from pods.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w jshr-w force-pushed the jshr/refactorces branch from f921876 to 057a560 Compare July 31, 2025 16:04
@giorio94
Copy link
Member

/test

@giorio94 giorio94 enabled auto-merge July 31, 2025 16:19
@jshr-w
Copy link
Contributor Author

jshr-w commented Aug 1, 2025

/ci-clustermesh

@giorio94 giorio94 added this pull request to the merge queue Aug 1, 2025
Merged via the queue into cilium:main with commit f77c847 Aug 1, 2025
68 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
feature/ces Impacts the Cilium Endpoint Slice logic. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshr-w @giorio94 @thorn3r