loadbalancer: Fix backend state in REST API #40780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Cilium LB controlplane introduced a new property `Unhealthy` on the backend params which allows for healthchecker extensions to report a backend as unhealthy. The LB backend selection respects the `State` & `Unhealthy` properties of the backend. While introducing the new property, there was an oversight of `cilium-dbg service list` which still shows the backend state as `active` even though the backend is reported as `unhealthy`. Therefore, this commit changes the LB REST API implementation to report the state of a backend as `quarantined` if `Unhealthy==true`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
|
/test |
joamaki
approved these changes
Jul 29, 2025
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Cilium LB controlplane introduced a new property
Unhealthyon the backend params which allows for healthchecker extensions to report a backend as unhealthy. The LB backend selection respects theState&Unhealthyproperties of the backend.While introducing the new property, there was an oversight of
cilium-dbg service listwhich still shows the backend state asactiveeven though the backend is reported asunhealthy.Therefore, this commit changes the LB REST API implementation to report the state of a backend as
quarantinedifUnhealthy==true.