Skip to content

Conversation

tklauser
Copy link
Member

Currently, missing test owners on a particula package lead to an error of the form

ERROR Failed to locate owner for package path=github.com/cilium/cilium/pkg/foo error="no owners defined"

potentially being reported multiple times1. De-duplicate the reported error log lines to de-clutter the logs in that case.

Footnotes

  1. https://github.com/cilium/cilium/actions/runs/16586570193/job/46912960231#step:15:779

@tklauser tklauser requested a review from a team as a code owner July 29, 2025 09:03
@tklauser tklauser added release-note/ci This PR makes changes to the CI. needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 29, 2025
@tklauser tklauser requested a review from qmonnet July 29, 2025 09:04
@tklauser tklauser enabled auto-merge July 29, 2025 09:04
@tklauser tklauser changed the title tools/testowners: de-duplicate errors logs tools/testowners: de-duplicate error logs Jul 29, 2025
Currently, missing test owners on a particula package lead to an error
of the form

    ERROR Failed to locate owner for package path=github.com/cilium/cilium/pkg/foo error="no owners defined"

potentially being reported multiple times[^1]. De-duplicate the reported
error log lines to de-clutter the logs in that case.

[^1]: https://github.com/cilium/cilium/actions/runs/16586570193/job/46912960231#step:15:779

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/testowners-deduplicate-warnings branch from 173fd08 to 4394604 Compare July 29, 2025 09:23
@tklauser
Copy link
Member Author

/test

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tklauser tklauser added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 32034ef Jul 29, 2025
307 of 308 checks passed
@tklauser tklauser deleted the pr/tklauser/testowners-deduplicate-warnings branch July 29, 2025 11:00
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 29, 2025
@rastislavs rastislavs mentioned this pull request Jul 31, 2025
14 tasks
@rastislavs rastislavs added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 31, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 4, 2025
@joestringer joestringer added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Aug 8, 2025
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
3 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Aug 11, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants