ipam: test to skip the sync #40760
Closed
ipam: test to skip the sync #40760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comment out the sync and add more eks tests to see it will resolve the issue #36428 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
|
/ci-eks |
|
Refering to #36428 (comment), @liyihuang changes under .github/ at not taken into account when opening a PR as it would be a security issue. Ex: Modify a workflow print all the secrets. Committers can test these type of changes in collab with you. |
|
/ci-eks |
1 similar comment
|
/ci-eks |
liyihuang
added a commit
to liyihuang/cilium
that referenced
this pull request
Aug 13, 2025
this is the temporary fix for ENI mode to avoid the sync from AWS getting the stale data since we would like to see if this can fix the CI issue for cilium#36428 based on the discussion here cilium#36428 (comment) if so, we will change how alibaba and azure behavior like PR cilium#37650 and remove this instanceSync trigger sync from here completely. I have tested skip this trigger sync with draft PR cilium#40760 for a few times and it seems to be working. we hope we can test this for 2-4 weeks so we can know if the CI issue got fixed. if we dont see the CI issue again, we will have the follow up PR to change Azure and Alibaba cloud and remove this trigger. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
liyihuang
added a commit
to liyihuang/cilium
that referenced
this pull request
Aug 14, 2025
this is the temporary fix for ENI mode to avoid the sync from AWS getting the stale data since we would like to see if this can fix the CI issue for cilium#36428 based on the discussion here cilium#36428 (comment) if so, we will change how alibaba and azure behavior like PR cilium#37650 and remove this instanceSync trigger sync from here completely. I have tested skip this trigger sync with draft PR cilium#40760 for a few times and it seems to be working. we hope we can test this for 2-4 weeks so we can know if the CI issue got fixed. if we dont see the CI issue again, we will have the follow up PR to change Azure and Alibaba cloud and remove this trigger. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
liyihuang
added a commit
to liyihuang/cilium
that referenced
this pull request
Aug 15, 2025
this is the temporary fix for ENI mode to avoid the sync from AWS getting the stale data since we would like to see if this can fix the CI issue for cilium#36428 based on the discussion here cilium#36428 (comment) if so, we will change how alibaba and azure behavior like PR cilium#37650 and remove this instanceSync trigger sync from here completely. I have tested skip this trigger sync with draft PR cilium#40760 for a few times and it seems to be working. we hope we can test this for 2-4 weeks so we can know if the CI issue got fixed. if we dont see the CI issue again, we will have the follow up PR to change Azure and Alibaba cloud and remove this trigger. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment out the sync and add more eks tests to see it will resolve the issue #36428
Fixes: #36428