Skip to content

build: Don't include bpf test files in cilium image #40634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

build: Don't include bpf test files in cilium image #40634

merged 1 commit into from
Jul 30, 2025

Conversation

HadrienPatte
Copy link
Member

Remove the following from the cilium image:

  • Test files: bpf/tests/ and bpf/complexity-tests/
  • Examples: bpf/custom/
  • Dev makefiles: bpf/Makefile and bpf/Makefile.bpf

Arguably, the filesize saved in the final image is probably negligible, but it's more about not embedding testing resources in the final image (similar idea as #34069)

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
build: Don't include `bpf` test files in cilium image

@HadrienPatte
build: Don't include bpf test files in cilium image
4599df0 
Remove the following from the cilium image:
* Test files: `bpf/tests/` and `bpf/complexity-tests/`
* Examples: `bpf/custom/`
* Dev makefiles: `bpf/Makefile` and `bpf/Makefile.bpf`

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2025
@HadrienPatte
Copy link
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review July 22, 2025 10:13
@HadrienPatte HadrienPatte requested a review from a team as a code owner July 22, 2025 10:13
@HadrienPatte HadrienPatte requested a review from borkmann July 22, 2025 10:13
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 22, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2025
@tklauser tklauser added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit a08fbd0 Jul 30, 2025
378 of 385 checks passed
@tklauser tklauser deleted the pr/HadrienPatte/bpf-tests branch July 30, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@borkmann borkmann Awaiting requested review from borkmann borkmann is a code owner automatically assigned from cilium/build

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HadrienPatte @tklauser @joestringer