loadbalancer: Use unique for L3n4Addr #40633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d58729d to
dc559e2
Compare
|
/test |
dc559e2 to
f1acff4
Compare
|
/test |
|
/scale-100 |
MrFreezeex
reviewed
Jul 23, 2025
MrFreezeex
approved these changes
Jul 23, 2025
ysksuzuki
approved these changes
Jul 24, 2025
glrf
approved these changes
Jul 24, 2025
tklauser
approved these changes
Jul 25, 2025
The L3n4Addr is used in a lot of places and is compared and hashed a lot. Reduce memory usage and speed up comparisons by making L3n4Addr a unique.Handle. pkg/loadbalancer/benchmark before: Min: Allocated 563043kB in total, 1837855 objects / 118158kB still reachable (per service: 36 objs, 11531B alloc, 2419B in-use) Avg: Allocated 583710kB in total, 2174642 objects / 154810kB still reachable (per service: 43 objs, 11954B alloc, 3170B in-use) Max: Allocated 643000kB in total, 3089878 objects / 263505kB still reachable (per service: 61 objs, 13168B alloc, 5396B in-use) After: Min: Allocated 510398kB in total, 1734286 objects / 83716kB still reachable (per service: 34 objs, 10452B alloc, 1714B in-use) Avg: Allocated 523617kB in total, 2188965 objects / 125627kB still reachable (per service: 43 objs, 10723B alloc, 2572B in-use) Max: Allocated 564751kB in total, 3478097 objects / 229608kB still reachable (per service: 69 objs, 11566B alloc, 4702B in-use) Signed-off-by: Jussi Maki <jussi@isovalent.com>
f1acff4 to
35f3d8d
Compare
|
/test |
|
Marking this as |
35f3d8d to
089b870
Compare
|
Reverted the |
|
/test |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The L3n4Addr is used in a lot of places and is compared and hashed a lot. Reduce memory usage and speed up comparisons by making L3n4Addr a unique.Handle. In the
pkg/loadbalancer/benchmarkthis is a 30% save on memory!The relevant change is to
pkg/loadbalancer/loadbalancer.go, other files are changed just to accomodate the new API.pkg/loadbalancer/benchmark before:
After: