helm: misc small cleanups with certgen job spec #40628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes serviceAccount that was deprecated for 10+ versions (see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#podspec-v1-core). And we also fix affinity key that was always added even when no affinity was specified. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
|
/test |
marseel
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes serviceAccount that was deprecated for 10+ versions (see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#podspec-v1-core).
And we also fix affinity key that was always added even when no affinity was specified.
Spotted by @giorio94 in #40506 as this linked PR is also adding another kind of job which I took most of the code from those other jobs.