Skip to content

vendor: Prevent renovate from updating gobgp dependency #40612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

vendor: Prevent renovate from updating gobgp dependency #40612

merged 1 commit into from
Jul 21, 2025

Conversation

HadrienPatte
Copy link
Member

We use a fork of github.com/osrg/gobgp/v3 (see #40566), this PR disables renovate from updating this dependency as it's currently breaking renovate automated updates, see #40593.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
vendor: Prevent renovate from updating gobgp dependency

@HadrienPatte
vendor: Prevent renovate from updating gobgp dependency
5cd14a8 
We use a fork of `github.com/osrg/gobgp/v3` (see #40566), this PR
disables renovate from updating this dependency as it's currently
breaking renovate automated updates, see #40593.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2025
@HadrienPatte
Copy link
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review July 21, 2025 11:23
@HadrienPatte HadrienPatte requested review from a team as code owners July 21, 2025 11:23
@HadrienPatte HadrienPatte requested review from aanm and Artyop July 21, 2025 11:23
@aanm aanm requested review from a team and rastislavs and removed request for a team July 21, 2025 11:47
aanm
aanm approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rastislavs

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jul 21, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2025
@aanm aanm added the dont-merge/waiting-for-review Requires further review before merging. label Jul 21, 2025
@aanm
Copy link
Member

aanm commented Jul 21, 2025

@rastislavs please remove the dont-merge/waiting-for-review label if you are ok with it.

@aanm aanm enabled auto-merge July 21, 2025 11:48
rastislavs
rastislavs approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will remove this once we go back to using the upstream version

@rastislavs rastislavs removed the dont-merge/waiting-for-review Requires further review before merging. label Jul 21, 2025
@aanm aanm added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit d4c3f29 Jul 21, 2025
83 checks passed
@aanm aanm deleted the pr/HadrienPatte/gobgp-renovate branch July 21, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@rastislavs rastislavs rastislavs approved these changes

@Artyop Artyop Awaiting requested review from Artyop Artyop is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HadrienPatte @aanm @rastislavs