Skip to content

clustermesh: enable policy-default-local-cluster by default #40609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2025
Merged

clustermesh: enable policy-default-local-cluster by default #40609

merged 2 commits into from
Jul 29, 2025

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jul 20, 2025 •
edited
Loading

Related to #36194
Some early warning docs was already here #40108 that we are referencing/re-hashing for the Cilium 1.19 upgrade

First commit is mainly about enabling this by default (helm + hive config) and regenerate the various files linked while the second commit updates the docs for this.

policy: clustermesh: policy-default-local-cluster is now set by default. See the upgrade guide for guidance on how to prepare your migration if you are using ClusterMesh and have network policies

@MrFreezeex MrFreezeex requested review from a team as code owners July 20, 2025 20:21
@MrFreezeex MrFreezeex requested review from giorio94 and marseel July 20, 2025 20:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 20, 2025
@MrFreezeex MrFreezeex added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. area/clustermesh Relates to multi-cluster routing functionality in Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 20, 2025
@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch from a26fe46 to aee561a Compare July 20, 2025 20:26
@MrFreezeex
Copy link
Member Author

/test

giorio94
giorio94 approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch from aee561a to bedb3bc Compare July 21, 2025 09:57
@MrFreezeex
Copy link
Member Author

/test

squeed
squeed reviewed Jul 21, 2025
View reviewed changes
@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch 3 times, most recently from ccc3d3f to 2f78c2c Compare July 21, 2025 22:15
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex requested a review from squeed July 21, 2025 22:28
@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch from 2f78c2c to 0ba84af Compare July 22, 2025 10:26
@MrFreezeex
Copy link
Member Author

/test

marseel
marseel approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@joestringer joestringer added the upgrade-impact This PR has potential upgrade or downgrade impact. label Jul 23, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 23, 2025
@giorio94
Copy link
Member

@MrFreezeex It seems that this PR picked a couple of conflicts, and needs a rebase.

@giorio94 giorio94 added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 28, 2025
@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch from 0ba84af to 54198f1 Compare July 28, 2025 09:26
@MrFreezeex
Copy link
Member Author

@MrFreezeex It seems that this PR picked a couple of conflicts, and needs a rebase.

Indeed thanks for the notice I just rebased!

@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 28, 2025
@giorio94 giorio94 enabled auto-merge July 28, 2025 09:34
@joestringer joestringer added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Jul 29, 2025
@joestringer
Copy link
Member

Needs another rebase sorry :)

@MrFreezeex
clustermesh: enable policy-default-local-cluster by default
b3faf37 
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex
docs: add upgrade recomendations for policy-default-local-cluster
2388b96 
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex MrFreezeex force-pushed the policy-default-local-cluster-enabled branch from 54198f1 to 2388b96 Compare July 29, 2025 22:01
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex mentioned this pull request Jul 29, 2025
Closed
@giorio94 giorio94 added this pull request to the merge queue Jul 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2025
@joestringer joestringer added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 09ae1f8 Jul 29, 2025
367 of 369 checks passed
@joestringer joestringer deleted the policy-default-local-cluster-enabled branch July 29, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@marseel marseel marseel approved these changes

@hemanthmalla hemanthmalla hemanthmalla approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. upgrade-impact This PR has potential upgrade or downgrade impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MrFreezeex @giorio94 @joestringer @squeed @marseel @hemanthmalla