Skip to content

Revert "endpoint, policy: Don't accidentally clear out endpoint policy maps" #40695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Revert "endpoint, policy: Don't accidentally clear out endpoint policy maps" #40695

merged 1 commit into from
Jul 24, 2025

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Jul 24, 2025 •
edited
Loading

This reverts commit f052828. This was not the version of #40255 that was approved by reviewers.

@joestringer
Revert "endpoint, policy: Don't accidentally clear out endpoint polic…
d2e8ef4 
…y maps"

This reverts commit f052828.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested review from a team as code owners July 24, 2025 23:01
@joestringer joestringer requested review from derailed and tklauser July 24, 2025 23:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Jul 24, 2025
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 24, 2025
@joestringer
Copy link
Member Author

Looking feedback on whether this was an intentional shift per #40255 (comment) , as the PR seemed to revert to an earlier proposal in the most recent rebase.

@joestringer joestringer removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2025
@joestringer joestringer merged commit 69f0086 into main Jul 24, 2025
58 of 59 checks passed
@joestringer joestringer deleted the pr/joe/revert-40255 branch July 24, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrife jrife jrife approved these changes

@derailed derailed Awaiting requested review from derailed derailed is a code owner automatically assigned from cilium/sig-policy

@tklauser tklauser Awaiting requested review from tklauser tklauser is a code owner automatically assigned from cilium/endpoint

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joestringer @jrife