ipcache: slightly reduce API surface #40671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not called from outside the package. Since it requires locking the IPCache mutex it's safer to have it unexported. Also change the internal uses of the public (*IPCache).RLock/RUnlock to the internal (*IPCache).mutex.RLock/RUnlock interface. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Since the last commit, these are not used anywhere in- or outside the package anymore. If they were, this would likely be an anti-pattern because it could easily lead to deadlocks. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
/test |
jrajahalme
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexport
(*IPCache).DumpToListenerLocked(which requires locking the IPCache mutex) and remove the now unused public Lock and Unlock methods.See commit messages for details.