docs: clarify Prometheus annotation logic for metrics #40532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies that Prometheus annotations are only present when ServiceMonitor is disabled. If enabled, Prometheus discovers metrics via the ServiceMonitor resource. Closes: cilium#21958 Signed-off-by: Rayyan Seliya <rayyanseliya786@gmail.com>
hemanthmalla
approved these changes
Jul 18, 2025
|
|
Hey @hemanthmalla @derailed can u please move forward for merging this pr I think it's ready ! |
|
/test |
|
hey @xmulligan thx for test and do i need to update the branch also ?? and yeah just wanted to have some guidance on my proposal any suggestions as i am now very much familiar with cilium with 2 prs merged and 1 pr pending and contributing more !! |
derailed
approved these changes
Aug 4, 2025
|
LGTM, merging thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Monitoring & Metrics documentation to clarify that Prometheus annotations (
prometheus.io/scrape,prometheus.io/port) are only present whenhubble.metrics.serviceMonitor.enabledis set tofalse. If ServiceMonitor is enabled, these annotations are omitted and Prometheus discovers metrics via the ServiceMonitor resource.Closes: #21958
See the screenshot here how it looks