Miscellaneous improvements to option.NewNamedMapOptions #40529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a potential pitfall and ensure that NewMapOptions correctly initializes the given map if nil, so that the values can be set properly. Currently, instead, the map is initialized, but the original pointer is not updated, which means that the caller has no ways to see the configured values. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The name parameter is only assigned, but never read, so we can drop it to simplify the callers. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Rework the NewMapOptions validator to actually perform validation only, rather than possibly mutating the values as well. Indeed, all validators are always passing through the given value, except the BPFMapEventBuffers one, but the returned values are never read in that case. Additionally, let's make the set of validators variadic, so that we can drop the nil parameter from all callers that don't set a validator. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
asauber
approved these changes
Jul 16, 2025
thorn3r
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few pitfalls associated with
option.NewNamedMapOptions, and simplify its API surface. Please refer to the individual commits for additional details.