build: Enforce docker build checks #40528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23ff55d to
24f3e2c
Compare
24f3e2c to
56c5853
Compare
christarazi
approved these changes
Jul 16, 2025
asauber
approved these changes
Jul 16, 2025
|
/test |
kaworu
approved these changes
Jul 30, 2025
Docker build checks are currently only being flagged on PRs by the `docker/build-push-action` action. With this PR, image builds will fail whenever there are docker build check failures. See [docker build checks](https://docs.docker.com/build/checks/). Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
4a2854e to
af05964
Compare
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
|
@cilium/docs-structure can someone please approve the docs-builder deployment? |
|
@qmonnet Thanks! It looks like it needs an additionnal approval for the Update Pull Request with new image reference step (and likely a final approval on the noop workflow run for the new commit that this workflow will push to this branch 😅) |
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
Yes I meant to come back here after the first deployment had run, and got distracted while working on something else 🙂 |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker build checks are currently only being flagged on PRs by the
docker/build-push-actionaction. With this PR, image builds will fail whenever there are docker build check failures.See docker build checks.
There are two main ways to enable enforcement of docker build checks:
# check=error=truecomment at the top of each DockerfileBUILDKIT_DOCKERFILE_CHECK=error=truebuild-arg in eachdocker buildcommandIn general it's easier to add the build arg in the central place where image builds are configured, that way all future Dockerfiles are garanteed to be covered. However in the case of the
cilium/ciliumrepository, it turns out that image builds are defined in a lot of places: indocker/build-push-action(10 individual occurences) workflows, but also inMakefile.dockerandimages/scripts/build-image.sh. As a result of this, it is more difficult to ensure continued coverage of all image build mechanisms, both those used locally and those used in CI. This is why I opted to add thecheck=error=truecomment in Dockerfiles instead.We can see an example of how a CI image build job now fails on check violations here:
As part of this PR, the
images/builder/Dockerfile,contrib/backporting/Dockerfileandcontrib/coccinelle/DockerfileDockerfiles are getting updated to fix existing check failures.Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.