Skip to content

refactor: removed previously deprecated -bpf-lb-proto-diff option. #40505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

refactor: removed previously deprecated -bpf-lb-proto-diff option. #40505

merged 2 commits into from
Jul 21, 2025

Conversation

Surya-7890
Copy link
Contributor

This commit removes -bpf-lb-proto-diff, that was marked as deprecated in v1.18.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #39328

@Surya-7890 Surya-7890 requested review from a team as code owners July 13, 2025 17:49
@Surya-7890 Surya-7890 requested a review from giorio94 July 13, 2025 17:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 13, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 13, 2025
@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jul 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 14, 2025
@giorio94 giorio94 added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/loadbalancing Impacts load-balancing and Kubernetes service implementations and removed kind/cleanup This includes no functional changes. labels Jul 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 14, 2025
giorio94
giorio94 requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Surya-7890 for taking care of this. I've left a few initial comments inline about additional clean-up that should be performed. Moreover, you should also rebase this PR onto the main branch to address the conflicts.

@Surya-7890 Surya-7890 force-pushed the refactor/1.19-remove-deprecated branch from 059b55d to 60e6bac Compare July 14, 2025 15:54
@Surya-7890 Surya-7890 requested a review from a team as a code owner July 16, 2025 04:31
@maintainer-s-little-helper
Copy link

Commits 057960a, 1e57434 do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 16, 2025
@Surya-7890 Surya-7890 force-pushed the refactor/1.19-remove-deprecated branch from 1e57434 to fed7c71 Compare July 16, 2025 04:56
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 16, 2025
tommyp1ckles
tommyp1ckles requested changes Jul 16, 2025
View reviewed changes
giorio94
giorio94 reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good to me. Just one cosmetic comment about the commits structure, in addition to Tom's. I'll trigger the full test suite once these are addressed.

@Surya-7890
changelog: remove v1.18-specific notes, update heading to v1.19
8015add 
This commit removes notes that are specific to v1.18.
The section heading has also been updated to v1.19.

Signed-off-by: surya <suryamariappan9108@gmail.com>
@Surya-7890
refactor: removed previously deprecated -bpf-lb-proto-diff option.
fc60ef5 
Fixes: cilium#39328

This commit removes the -bpf-lb-proto-diff option, which was marked as deprecated in v1.18.

Signed-off-by: surya <suryamariappan9108@gmail.com>
@Surya-7890 Surya-7890 force-pushed the refactor/1.19-remove-deprecated branch from fed7c71 to fc60ef5 Compare July 17, 2025 04:50
@Surya-7890 Surya-7890 requested a review from a team as a code owner July 17, 2025 04:50
@Surya-7890 Surya-7890 requested a review from gandro July 17, 2025 04:50
@Surya-7890
Copy link
Contributor Author

I had to rebase, as some files in bpf/complexity-tests were deleted in this PR

giorio94
giorio94 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks!

@giorio94
Copy link
Member

/test

@giorio94 giorio94 enabled auto-merge July 17, 2025 09:13
@giorio94 giorio94 requested a review from tommyp1ckles July 18, 2025 14:27
tommyp1ckles
tommyp1ckles approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s changes lgtm, thanks !

aditighag
aditighag approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giorio94
Copy link
Member

@cilium/docs-structure Gentle ping 🙏

@borkmann borkmann disabled auto-merge July 21, 2025 12:06
@borkmann borkmann merged commit afd5e64 into cilium:main Jul 21, 2025
74 checks passed
This was referenced Jul 22, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@borkmann borkmann borkmann approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@rgo3 rgo3 rgo3 approved these changes

@aditighag aditighag aditighag approved these changes

@giorio94 giorio94 giorio94 approved these changes

@asauber asauber Awaiting requested review from asauber asauber is a code owner automatically assigned from cilium/cli

@hemanthmalla hemanthmalla Awaiting requested review from hemanthmalla hemanthmalla is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loadbalancing Impacts load-balancing and Kubernetes service implementations kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.19] agent: remove --bpf-lb-proto-diff
7 participants
@Surya-7890 @giorio94 @gandro @borkmann @tommyp1ckles @rgo3 @aditighag