multicast: use Go 1.20 slice-to-array conversion for SolicitedNodeMaddr() #40591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dr() Go 1.20 introduced slice-to-array conversions, which allow directly casting a slice to an array. This commit updates the Address.SolicitedNodeMaddr() method to use the cleaner [16]byte(slice) syntax instead of *(*[16]byte)(slice). Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>
|
/test |
tklauser
requested changes
Jul 22, 2025
There was a problem hiding this comment.
@suchit07-git thanks for the PR. Could you also apply the same change at
cilium/pkg/multicast/multicast_test.go
Line 70 in cab0cce
Use Go 1.20 slice-to-array conversion syntax in randMaddr() function Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>
auto-merge was automatically disabled
July 22, 2025 10:23
Head branch was pushed to by a user without write access
Done @tklauser |
|
/test |
tklauser
approved these changes
Jul 22, 2025
harsimran-pabla
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 introduced slice-to-array conversions, which allow directly casting a slice to an array. This commit updates the Address.SolicitedNodeMaddr() method to use the cleaner [16]byte(slice) syntax instead of *(*[16]byte)(slice) as mentioned in the TODO.