Skip to content

Conversation

Andreagit97
Copy link
Contributor

In these hairpin tests, we call ctx_redirect and not ctx_redirect_peer because ENABLE_HOST_ROUTING is not defined, so it shouldn't be necessary to mock it. I tried to put a log there, and I can see that it is never called running -test=tc_nodeport_test

In these hairpin tests we call `ctx_redirect` and not
`ctx_redirect_peer` because `ENABLE_HOST_ROUTING` is not defined.

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97 Andreagit97 requested a review from a team as a code owner July 19, 2025 15:19
@Andreagit97 Andreagit97 requested a review from ldelossa July 19, 2025 15:19
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 19, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 19, 2025
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks to be dead code.

Thanks a lot.

@ldelossa ldelossa added the release-note/misc This PR makes changes that have no direct user impact. label Jul 30, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 30, 2025
@ldelossa
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 30, 2025
@ldelossa ldelossa added this pull request to the merge queue Jul 30, 2025
Merged via the queue into cilium:main with commit ec173a1 Jul 30, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants