bgp: Use private fork of the GoBGP to fix BGP MD5 auth #40566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporally use the private fork of the GoBGP to fix the issue of BGP MD5 authentication reported in cilium#40478. We could wait for the next GoBGP release, but the next release is going to be a major version update, so it may take time before release and may have some bugs. Therefore, we fork the GoBGP from the last release of the current major version (v3.37.0) and apply MD5 fix and use it until we migrate to the new major GoBGP version. Fixes: cilium#40478 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
|
/test |
tklauser
approved these changes
Jul 18, 2025
23 tasks
10 tasks
5 tasks
8 tasks
rabelmervin
pushed a commit
to rabelmervin/cilium
that referenced
this pull request
Aug 18, 2025
We use a fork of `github.com/osrg/gobgp/v3` (see cilium#40566), this PR disables renovate from updating this dependency as it's currently breaking renovate automated updates, see cilium#40593. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporally use the private fork of the GoBGP to fix the issue of BGP MD5 authentication reported in #40478. We could wait for the next GoBGP release, but the next release is going to be a major version update, so it may take time before release and may have some bugs. Therefore, we fork the GoBGP from the last release of the current major version (v3.37.0) and apply MD5 fix and use it until we migrate to the new major GoBGP version.
The forked repo and branch is here: https://github.com/cilium/gobgp/tree/v3.37.0-with-fix
We request backporting to the v1.18 - v1.16 since they are also affected (as they are using Go >= v1.24) and without this change, BGP MD5 auth doesn't work at all. We consider it as a "Major bugfixes relevant to the correct operation of Cilium" in the backporting criteria.
Fixes: #40478