Skip to content

Conversation

jrife
Copy link
Contributor

@jrife jrife commented Jul 17, 2025

llvm-strip is a requirement for bpf2go, which I'm using in #38693 to generate eBPF bytecode and skeletons. As a follow up to cilium/image-tools#364, add llvm-strip to the builder image to unblock #38693.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 17, 2025
@jrife jrife had a problem deploying to release-base-images July 17, 2025 16:34 — with GitHub Actions Error
@jrife jrife force-pushed the jrife/llvm-strip branch from 5a7d31c to 677963f Compare July 17, 2025 16:39
@jrife jrife had a problem deploying to release-base-images July 17, 2025 16:39 — with GitHub Actions Error
@jrife jrife force-pushed the jrife/llvm-strip branch from 677963f to 3b3cdae Compare July 17, 2025 16:42
@jrife jrife had a problem deploying to release-base-images July 17, 2025 16:42 — with GitHub Actions Error
@jrife jrife changed the title images: Add llvm-strip to builder images: update cilium-builder Jul 17, 2025
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Jul 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 17, 2025
Add llvm-strip to the builder image.

Signed-off-by: Jordan Rife <jrife@google.com>
@jrife jrife force-pushed the jrife/llvm-strip branch from 1e6d416 to 7ebfbe9 Compare July 17, 2025 17:16
@jrife jrife had a problem deploying to release-base-images July 17, 2025 17:17 — with GitHub Actions Error
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@auto-committer auto-committer bot temporarily deployed to release-base-images July 17, 2025 17:41 Inactive
@jrife
Copy link
Contributor Author

jrife commented Jul 17, 2025

/test

@jrife jrife marked this pull request as ready for review July 17, 2025 18:19
@jrife jrife requested review from a team as code owners July 17, 2025 18:19
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 18, 2025
@jrife
Copy link
Contributor Author

jrife commented Jul 18, 2025

/test

@pchaigno pchaigno enabled auto-merge July 18, 2025 07:07
@pchaigno pchaigno added this pull request to the merge queue Jul 18, 2025
Merged via the queue into cilium:main with commit 0ab441a Jul 18, 2025
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants