Skip to content

Conversation

smagnani96
Copy link
Contributor

@smagnani96 smagnani96 commented Jul 9, 2025

This commit updates the e2e-upgrade and ipsec-upgrade workflows to not run the north-south connection disruption test on 5.4 kernel when downgrading Cilium version. In #39443 we introduced the fix, using a kernel variable that will be sanitized and compared against version "5.4" to skip the test. This commit completes the fix by adding the check also when downgrading Cilium, otherwise the flake "FIB lookup failed" would still happen in the downgrade case.

Fixes: #40369

This commit updates the e2e-upgrade and ipsec-upgrade workflows to
not run the north-south connection disruption test on 5.4 kernel when
downgrading Cilium version. In #39443 we introduced the fix, using a
`kernel` variable that will be sanitized and compared against version
"5.4" to skip the test. This commit completes the fix by adding the
check also when downgrading Cilium, otherwise the flake "FIB lookup failed"
would still happen in the downgrade case.

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
@smagnani96 smagnani96 self-assigned this Jul 9, 2025
@smagnani96 smagnani96 added area/CI Continuous Integration testing issue or flake kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. labels Jul 9, 2025
@smagnani96
Copy link
Contributor Author

/test

@smagnani96 smagnani96 requested review from nbusseneau and Artyop July 9, 2025 11:13
@smagnani96 smagnani96 marked this pull request as ready for review July 9, 2025 13:03
@smagnani96 smagnani96 requested review from a team as code owners July 9, 2025 13:03
@smagnani96
Copy link
Contributor Author

From the CI run, it looks like now we do have the correct version set both before upgrading and before downgrading, which should lead to skipping the test in kernel v5.4 as we expect.

@pchaigno pchaigno removed request for nbusseneau and Artyop July 9, 2025 13:11
@pchaigno pchaigno added this pull request to the merge queue Jul 9, 2025
Merged via the queue into v1.17 with commit 649c1e7 Jul 9, 2025
126 checks passed
@pchaigno pchaigno deleted the pr/smagnani96/fix-ignore-ns-tests-v1.17 branch July 9, 2025 13:22
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 9, 2025
@smagnani96 smagnani96 linked an issue Jul 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.17] CI: Cilium IPsec upgrade - FIB lookup failed
3 participants