Skip to content

Conversation

fristonio
Copy link
Member

  • Fix missing error return in policy repo GetSelectorPolicy() method
  • Redact sensitive TLS key information for logging.

Backport for - c22cc3c

Fixes: #39535
Fixes: 52d61cb ("policy: gather policy calculation in the repository")

policy: fix error handling for selector policy resolution

fristonio and others added 2 commits July 7, 2025 18:11
Signed-off-by: fristonio <deepeshpathak09@gmail.com>
If policy calculation failed, we didn't return the error when we should.

Fixes: 52d61cb ("policy: gather policy calculation in the repository")

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@fristonio fristonio requested a review from a team as a code owner July 8, 2025 02:00
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jul 8, 2025
@fristonio fristonio added kind/bug This is a bug in the Cilium logic. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. labels Jul 8, 2025
@fristonio fristonio requested a review from squeed July 8, 2025 02:01
@fristonio fristonio added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Jul 8, 2025
@fristonio
Copy link
Member Author

fristonio commented Jul 8, 2025

/test
Edit: IPSec upgrade test failure - #40369

Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@fristonio fristonio changed the title Fix missing return error in GetSelectorPolicy() [v1.17] Fix missing return error in GetSelectorPolicy() Jul 8, 2025
@joestringer joestringer merged commit 6379c4f into cilium:v1.17 Jul 8, 2025
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants