v1.17: helm: Restore hostPort.enabled flag #40480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7617cd to
f671e40
Compare
|
/test |
giorio94
reviewed
Jul 11, 2025
f671e40 to
89e45bd
Compare
giorio94
approved these changes
Jul 11, 2025
The [1] commit removed the hostPort.enabled too early. It will be no longer possible to enable each individual KPR flag only in v1.19. So, before that we need to support enabling HostPort when KPR=false. [1] got backported to v1.17 by #40222 to fix [2]. NB: we did not restore externalIPs.enabled, because it is no-op when KPR=false, and it is implicitly enabled when nodePort.enabled is true. [1]: 88d1e70 [2]: #40073 Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
89e45bd to
22ac4a8
Compare
|
/test |
|
@cilium/release-managers this seems useful to get into the v1.17 tree to avoid a regression in the next patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [1] commit removed the hostPort.enabled too early. It will be no longer possible to enable each individual KPR flag only in v1.19. So, before that we need to support enabling HostPort when KPR=false.
[1] got backported to v1.17 by #40222 to fix [2].
NB: we did not restore externalIPs.enabled, because it is no-op when KPR=false, and it is implicitly enabled when nodePort.enabled is true.
[1]: 88d1e70
[2]: #40073