eni: use sane defaults when enabling ENI via helm #40445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, enabling ENI in the Helm chart by setting eni.enabled=true is not sufficient. Users are also required to manually set additional values to avoid conflicting configurations: - routingMode must be explicitly set to native, otherwise the chart defaults to configuring a VXLAN interface — which is mutually exclusive with ENI in Cilium. - ipam.mode must be explicitly set to eni, otherwise the default cluster-pool IPAM remains enabled — which is also incompatible with ENI. These extra required settings are not obvious and can lead to misconfiguration and deployment issues. Signed-off-by: Filip Nikolic <oss.filipn@gmail.com>
marseel
approved these changes
Jul 10, 2025
Signed-off-by: Filip Nikolic <oss.filipn@gmail.com>
|
/test |
|
Is the issue also present on supported stable versions? Please check, and add the relevant |
I would vote for not backporting this. I think this is a UX improvement, not a bug per se, as the old required values were documented. |
gandro
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, enabling ENI in the Helm chart by setting
eni.enabled=trueis not sufficient. Users are also required to manually set additional values to avoid conflicting configurations:routingModemust be explicitly set tonative, otherwise the chart defaults to configuring a VXLAN interface — which is mutually exclusive with ENI in Cilium.ipam.modemust be explicitly set to eni, otherwise the defaultcluster-poolIPAM remains enabled — which is also incompatible with ENI.These extra required settings are not obvious and can lead to misconfiguration and deployment issues.
This PR updates the chart logic to automatically handle these dependencies when the user sets
eni.enabled=true.