bgp: Reset peers properly upon policy update with empty MatchNeighbors #40339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b65c15e to
a452df9
Compare
|
/test |
rastislavs
approved these changes
Jul 3, 2025
|
/test |
Introduce a new ResetAllNeighbors method to the Router interface. This is similar to the ResetNeighbor, but allows caller to reset all neighbors configured on the given router without explicitly specifying peer address. This is used to do soft resetting for all peers when we update the route policy that affects to all peers (the route policy with empty MatchNeighbors). Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
The policy with empty MatchNeighbors matches all neighbors. However, we don't reset any peers upon the update of such policies today. To fix that, extend the existing soft reset handling logic to handle empty MatchNeighbors case by resetting all peers when the update for such policy occurs. In all reset case, we need a special treatment, because route policy reconciler doesn't have a full list of neighbors, so doesn't know how to reset "all" peers. To deal with it, we use the ResetAllNeighbors we introduced in the previous commit. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
a452df9 to
25fef71
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy with empty MatchNeighbors matches all neighbors. However, we don't reset any peers upon the update of such policies today. Handle those case properly.