Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jul 2, 2025

In the past, we were creating and updating CRDs in Agent and because of that we were doing that in parallel to speed up bootstrap. Related to #12719

However, since we started creating and updating CRDs in operator, this is no longer necessary and can actually cause problems in large clusters: #39267

operator: CRDs are updated in series instead of in parallel now during Cilium upgrades. This should lower the pressure on the k8s control plane

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2025
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 2, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2025
In the past, we were creating and updating CRDs in Agent and because of
that we were doing that in parallel to speed up bootstrap. Related to cilium#12719

However, since we started creating and updating CRDs in operator, this
is no longer necessary and can actually cause problems in large
clusters: cilium#39267

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/create_crd_in_series branch from 3c803a9 to 7034d08 Compare July 2, 2025 09:45
@marseel marseel changed the title k8s: update CRDs in series instead of in parallel operator: update CRDs in series instead of in parallel Jul 2, 2025
@marseel
Copy link
Contributor Author

marseel commented Jul 2, 2025

/test

@marseel marseel marked this pull request as ready for review July 2, 2025 11:18
@marseel marseel requested a review from a team as a code owner July 2, 2025 11:18
@marseel marseel requested a review from tommyp1ckles July 2, 2025 11:18
@marseel marseel requested a review from tommyp1ckles July 8, 2025 08:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 8, 2025
@tklauser tklauser added this pull request to the merge queue Jul 11, 2025
Merged via the queue into cilium:main with commit 3356222 Jul 11, 2025
74 checks passed
@joestringer joestringer added the needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch label Jul 30, 2025
@joestringer
Copy link
Member

Nominating for v1.18 backport, related discussion here: #38467 (comment)

@rastislavs rastislavs mentioned this pull request Jul 31, 2025
14 tasks
@rastislavs rastislavs added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 31, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants