Skip to content

Backport: kube-proxy-healthz to return 503 if node terminating #40317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Backport: kube-proxy-healthz to return 503 if node terminating #40317

merged 1 commit into from
Jul 3, 2025

Conversation

tamilmani1989
Copy link
Contributor

@tamilmani1989 tamilmani1989 commented Jul 2, 2025 •
edited
Loading

This PR addresses this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3836-kube-proxy-improved-ingress-connectivity-reliability#implementation-history. kubeproxy healthz handler should return 503 if node is being deleted. Leverage local node watcher to watch for deletion events and added IsBeingDeleted field in LocalNode structure. IsBeingDeleted field will be set to true on node deletion. Kube-proxy health handler will get local node details and if IsBeingDeleted set, it returns 503 (ServiceUnavailable) error.

Backport of #40166

covered what skipped in this PR: #40289

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@tamilmani1989 tamilmani1989 requested a review from a team as a code owner July 2, 2025 00:39
@tamilmani1989 tamilmani1989 requested a review from pippolo84 July 2, 2025 00:39
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jul 2, 2025
@tamilmani1989 tamilmani1989 mentioned this pull request Jul 2, 2025
Merged
8 tasks
pippolo84
pippolo84 requested changes Jul 2, 2025
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport!

Overall LGTM, there is just an unneeded mock to remove from the kubeproxyhealtz test.

@tamilmani1989
chore: kube-proxy-healthz to return 503 if node terminating
80d8541 
This PR addresses this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3836-kube-proxy-improved-ingress-connectivity-reliability#implementation-history.
kubeproxy healthz handler should return 503 if node is being deleted. Leverage local node watcher to watch for deletion events and added `IsBeingDeleted` field in LocalNode structure. `IsBeingDeleted` field will be set to true on node deletion. Kube-proxy health handler will get local node details and if  `IsBeingDeleted` set, it returns 503 (ServiceUnavailable) error.

Signed-off-by: Tamilmani <tamanoha@microsoft.com>
@tamilmani1989 tamilmani1989 force-pushed the tm/kubeproxy_health_node_deletion_v1.17 branch from d50e2ab to 80d8541 Compare July 2, 2025 16:44
@pippolo84 pippolo84 self-requested a review July 3, 2025 08:07
pippolo84
pippolo84 approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pippolo84
Copy link
Member

/test

@pippolo84 pippolo84 enabled auto-merge July 3, 2025 19:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 3, 2025
@pippolo84 pippolo84 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into cilium:v1.17 with commit 45c6923 Jul 3, 2025
61 checks passed
@tklauser tklauser mentioned this pull request Jul 18, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

Assignees
No one assigned
Labels
backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamilmani1989 @pippolo84