v1.16 Backports 2025-06-26 #40226
Merged
v1.16 Backports 2025-06-26 #40226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit cb9bcd8 ] In production clusters with several secrets, these messages may flood the operator logs since they are also logged in case of no changes (action=ignored). Example from a recent sysdump: $ grep "Reconciling secret" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l 36789 $ grep "Successfully reconciled Secret.*action=ignored" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l 36789 Decrease the log level to debug so the messages still appear in CI and during development, but their value in production clusters is limited. [ Backporter's notes: - resolved conflicts in: operator/pkg/secretsync/secretsync_reconcile.go ] Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
|
/test |
tklauser
approved these changes
Jun 26, 2025
|
Thanks Viktor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: