Skip to content

deps: Replace gopkg.in/yaml.v3 with go.yaml.in/yaml/v3 #40224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

deps: Replace gopkg.in/yaml.v3 with go.yaml.in/yaml/v3 #40224

merged 1 commit into from
Jun 27, 2025

Conversation

HadrienPatte
Copy link
Member

@HadrienPatte HadrienPatte commented Jun 26, 2025 •
edited
Loading

This PR does four main things:

Fixes #39235

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
deps: Replace gopkg.in/yaml.v3 with go.yaml.in/yaml/v3

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2025
@github-actions github-actions bot added hubble-cli PRs or GitHub issues related with hubble-cli cilium-cli This PR contains changes related with cilium-cli labels Jun 26, 2025
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/yaml branch from 41f28b5 to e5b1569 Compare June 26, 2025 11:33
@HadrienPatte HadrienPatte marked this pull request as ready for review June 26, 2025 11:57
@HadrienPatte HadrienPatte requested review from a team as code owners June 26, 2025 11:57
rolinh
rolinh approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

@joamaki
Copy link
Contributor

joamaki commented Jun 26, 2025

Could you bump cilium/statedb to https://github.com/cilium/statedb/releases/tag/v0.4.4 to pull in an important fix?

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jun 26, 2025
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/yaml branch from e5b1569 to 9531ca7 Compare June 26, 2025 15:17
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2025
HadrienPatte
HadrienPatte commented Jun 26, 2025
View reviewed changes
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/yaml branch 2 times, most recently from 2ef6a4c to ed9173e Compare June 26, 2025 15:22
@joamaki joamaki added the release-blocker/1.18 This issue will prevent the release of the next version of Cilium. label Jun 27, 2025
@joamaki
Copy link
Contributor

joamaki commented Jun 27, 2025 •
edited
Loading

Marked as release blocker due to the important StateDB version bump.

And rebased this for you to fix the go.mod conflict.

@HadrienPatte @joamaki
deps: Replace gopkg.in/yaml.v3 with go.yaml.in/yaml/v3
5908d48 
Fixes: #39235

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@joamaki joamaki force-pushed the pr/HadrienPatte/yaml branch from ed9173e to 5908d48 Compare June 27, 2025 09:21
@joamaki
Copy link
Contributor

joamaki commented Jun 27, 2025

/test

@joamaki joamaki enabled auto-merge June 27, 2025 10:03
@joamaki joamaki removed the request for review from aspsk June 27, 2025 10:23
derailed
derailed approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HadrienPatte Thank you for this update!

@joamaki joamaki added this pull request to the merge queue Jun 27, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 27, 2025
Merged via the queue into main with commit f9cb5d2 Jun 27, 2025
378 of 381 checks passed
@joamaki joamaki deleted the pr/HadrienPatte/yaml branch June 27, 2025 15:10
@github-project-automation github-project-automation bot moved this from Proposed to Done in Release blockers Jun 27, 2025
@aditighag aditighag mentioned this pull request Jun 27, 2025
Open
@joamaki joamaki mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@squeed squeed squeed approved these changes

@joamaki joamaki joamaki approved these changes

@rolinh rolinh rolinh approved these changes

@marseel marseel marseel approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli hubble-cli PRs or GitHub issues related with hubble-cli ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.18 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
Release blockers
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML go library
8 participants
@HadrienPatte @joamaki @derailed @squeed @rolinh @marseel @viktor-kurchenko @tklauser