Skip to content

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jun 26, 2025

In production clusters with several secrets, these messages may flood the operator logs since they are also logged in case of no changes (action=ignored). Example from a recent sysdump:

$ grep "Reconciling secret" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l
36789
$ grep "Successfully reconciled Secret.*action=ignored" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l
36789

Decrease the log level to debug so the messages still appear in CI and during development, but their value in production clusters is limited.

In production clusters with several secrets, these messages may flood
the operator logs since they are also logged in case of no changes
(action=ignored). Example from a recent sysdump:

    $ grep "Reconciling secret" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l
    36789
    $ grep "Successfully reconciled Secret.*action=ignored" logs-cilium-operator-<redacted>-cilium-operator-20250626-083319.log | wc -l
36789

Decrease the log level to debug so the messages still appear in CI and
during development, but their value in production clusters is limited.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested review from a team as code owners June 26, 2025 08:10
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jun 26, 2025
@tklauser tklauser requested a review from sayboras June 26, 2025 08:10
@tklauser tklauser added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Jun 26, 2025
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge June 26, 2025 08:10
@tklauser tklauser added affects/v1.15 This issue affects v1.15 branch affects/v1.16 This issue affects v1.16 branch labels Jun 26, 2025
@tklauser tklauser added needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed affects/v1.15 This issue affects v1.15 branch affects/v1.16 This issue affects v1.16 branch labels Jun 26, 2025
@tklauser tklauser added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit cb9bcd8 Jun 26, 2025
324 of 327 checks passed
@tklauser tklauser deleted the pr/tklauser/secretsync-silence-logs branch June 26, 2025 10:19
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 26, 2025
@viktor-kurchenko viktor-kurchenko added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.15 labels Jun 26, 2025
@viktor-kurchenko viktor-kurchenko removed the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Jun 26, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jun 26, 2025
@tklauser tklauser mentioned this pull request Jul 1, 2025
4 tasks
@tklauser tklauser added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jul 1, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants