Skip to content

pkg/egressgateway: ensure gateway IP is IPv4 #40209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

pkg/egressgateway: ensure gateway IP is IPv4 #40209

merged 1 commit into from
Jul 2, 2025

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Jun 25, 2025

If the agent assigns a IPv6 IP as the gateway IP packets will be dropped because the egress gateway feature doesn't support a IPv6 underlay. This commit ensures the IP chosen as the gateway IP is IPv4.

Fixes: #39985

@rgo3
pkg/egressgateway: ensure gateway IP is IPv4
4086624 
If the agent assigns a IPv6 IP as the gateway IP packets will be dropped
because the egress gateway feature doesn't support a IPv6 underlay. This
commit ensures the IP chosen as the gateway IP is IPv4.

Fixes: #39985

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 25, 2025
@rgo3 rgo3 added release-note/bug This PR fixes an issue in a previous release of Cilium. feature/egress-gateway Impacts the egress IP gateway feature. labels Jun 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 25, 2025
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 25, 2025

/test

@rgo3 rgo3 marked this pull request as ready for review June 26, 2025 21:58
@rgo3 rgo3 requested a review from a team as a code owner June 26, 2025 21:58
@rgo3 rgo3 requested a review from ysksuzuki June 26, 2025 21:58
lamacorp-bot pushed a commit to LamaCorp/infra-infrastructure that referenced this pull request Jun 27, 2025
@rissson
k8s/core/cilium: use dev image tag for egressgateway issue
f2b05b0 
See cilium/cilium#39985
See cilium/cilium#40209

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@lama-corp.space>
ysksuzuki
ysksuzuki approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 30, 2025
@pchaigno pchaigno added this pull request to the merge queue Jul 2, 2025
@pchaigno
Copy link
Member

pchaigno commented Jul 2, 2025

We should also reject this configuration I think (egressgw + IPv6 underlay).

@rgo3 rgo3 added backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch and removed backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. labels Jul 2, 2025
Merged via the queue into main with commit 2d0825e Jul 2, 2025
388 of 395 checks passed
@pchaigno pchaigno deleted the pr/rgo3/egw-ensure-v4-gateway branch July 2, 2025 09:37
@tklauser tklauser mentioned this pull request Jul 2, 2025
Merged
2 tasks
@tklauser tklauser added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jul 2, 2025
@tklauser tklauser mentioned this pull request Jul 2, 2025
Merged
2 tasks
@tklauser tklauser added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jul 2, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jul 2, 2025
@pippolo84 pippolo84 mentioned this pull request Jul 7, 2025
Merged
7 tasks
@pippolo84 pippolo84 added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 7, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

Assignees
No one assigned
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Egress Gateway reports Gateway IP as not found
5 participants
@rgo3 @pchaigno @ysksuzuki @tklauser @pippolo84