Skip to content

lint: Update staticcheck config in golangci-lint #40201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

lint: Update staticcheck config in golangci-lint #40201

merged 1 commit into from
Jun 26, 2025

Conversation

sayboras
Copy link
Member

Keep the sensible default values from upstream, and a few extra disabled checks applicable to Cilium.

Fixes: #40197

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 25, 2025
@github-actions github-actions bot added sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. cilium-cli This PR contains changes related with cilium-cli labels Jun 25, 2025
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Jun 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 25, 2025
@sayboras sayboras force-pushed the pr/tammach/staticcheck-lint branch from 9c5733d to 18b4d97 Compare June 25, 2025 05:27
@sayboras
lint: Update staticcheck config in golangci-lint
840cf37 
Keep the sensible default values from upstream, and a few extra disabled
checks applicable to Cilium.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/staticcheck-lint branch from 18b4d97 to 840cf37 Compare June 25, 2025 05:28
@sayboras sayboras marked this pull request as ready for review June 25, 2025 06:03
@sayboras sayboras requested review from a team as code owners June 25, 2025 06:03
@aanm
Copy link
Member

aanm commented Jun 25, 2025

/test

@aanm aanm enabled auto-merge June 25, 2025 07:19
derailed
derailed approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayboras Nice clean up. Thank you!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 26, 2025
@aanm aanm added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 5fcf2e6 Jun 26, 2025
393 of 400 checks passed
@aanm aanm deleted the pr/tammach/staticcheck-lint branch June 26, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@rolinh rolinh rolinh approved these changes

@marseel marseel marseel approved these changes

@christarazi christarazi christarazi approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@aanm aanm aanm approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: specifying checks in .golangci.yaml for staticcheck disables all default checks
10 participants
@sayboras @aanm @derailed @rolinh @marseel @christarazi @ysksuzuki @jrajahalme @mhofstetter @bimmlerd