cilium-cli: Print partial output upon bgp peers errors
#40278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In clusters with multiple nodes, some of the cilium-agents may be in non-running state (e.g. init, crashloop, pending etc.). Instead of just erroring out completely, print the output for the nodes that are running, and error messages for the nodes where the bgp peer status retrieval failed. Same behavior is already present for bgp routes output. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clusters with multiple nodes, some of the cilium-agents may be in non-running state (e.g. init, crashloop, pending etc.). Instead of just erroring out completely, print the output for the nodes that are running, and error messages for the nodes where the bgp peer status retrieval failed.
Same behavior is already present for bgp routes output.