Skip to content

Conversation

atykhyy
Copy link
Contributor

@atykhyy atykhyy commented Jun 28, 2025

This PR reverts commit 59b97ee ("maps/policymap, daemon: Create policy maps from daemon"). Endpoint manager is newly created and empty at the point where d.initMaps() is called, so the loop over endpoints does nothing (and never did anything).

Reverts commit 59b97ee ("maps/policymap, daemon: Create policy maps
from daemon"). Endpoint manager is newly created and empty at the point
where `d.initMaps()` is called, so the loop over endpoints does nothing.

Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
@atykhyy atykhyy requested review from a team as code owners June 28, 2025 09:51
@atykhyy atykhyy requested review from aspsk and jrajahalme June 28, 2025 09:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 28, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 28, 2025
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

cc @pchaigno as original author.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 1, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2025
@joestringer
Copy link
Member

/test

@joestringer joestringer removed the request for review from aspsk July 1, 2025 22:44
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting one of my very first commits in Cilium 😅

@pchaigno pchaigno enabled auto-merge July 2, 2025 08:50
@joestringer
Copy link
Member

I triaged the failures and one is #39855, while the other is introduced because the PR is not rebased against the tip of main (but the tests were run from the tip of main). I'm OK with merging as-is, but a rebase might help to resolve the failures.

Otherwise just waiting on @cilium/endpoint review before merge.

@joestringer joestringer self-assigned this Jul 3, 2025
@joestringer joestringer disabled auto-merge July 7, 2025 17:31
@joestringer joestringer merged commit 73226a6 into cilium:main Jul 7, 2025
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants