Skip to content

tools: Move codeowners library from cilium-cli dir #40253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Jun 27, 2025

During creation of the v1.18 branch, it was problematic to have this
library live in cilium-cli due to other assumptions made in the tree
about the ability to delete this directory while creating a stable
branch. Move this library to another location so we can just delete the
cilium-cli directory on stable branches.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 27, 2025
@joestringer joestringer requested review from a team as code owners June 27, 2025 19:27
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 27, 2025
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Jun 27, 2025
@joestringer joestringer mentioned this pull request Jun 27, 2025
6 tasks
During creation of the v1.18 branch, it was problematic to have this
library live in cilium-cli due to other assumptions made in the tree
about the ability to delete this directory while creating a stable
branch. Move this library to another location so we can just delete the
cilium-cli directory.

Signed-off-by: Joe Stringer <joe@isovalent.com>
@joestringer joestringer force-pushed the pr/joe/mv-codeowners-lib branch from 39407fa to bad7258 Compare June 27, 2025 19:32
@joestringer joestringer reopened this Jun 27, 2025
@joestringer
Copy link
Member Author

/test

@joestringer joestringer enabled auto-merge June 27, 2025 21:46
@joestringer joestringer disabled auto-merge June 30, 2025 17:38
@joestringer joestringer merged commit e0edd40 into main Jun 30, 2025
337 of 350 checks passed
@joestringer joestringer deleted the pr/joe/mv-codeowners-lib branch June 30, 2025 17:38
@joestringer joestringer added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Aug 7, 2025
@joestringer joestringer added the backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. label Aug 12, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants