Skip to content

docs: Clarify use of routing table IDs in Cilium. #40248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

docs: Clarify use of routing table IDs in Cilium. #40248

merged 1 commit into from
Jul 16, 2025

Conversation

nocturo
Copy link
Contributor

@nocturo nocturo commented Jun 27, 2025

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This amends documentation to add information about the route table IDs used by Cilium.

Fixes: #38531

@nocturo nocturo requested review from a team as code owners June 27, 2025 12:47
@nocturo nocturo requested review from aspsk and qmonnet June 27, 2025 12:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 27, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 27, 2025
qmonnet
qmonnet requested changes Jun 27, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please find some minor suggestions below.

Note (to Anton): I reviewed for docs-structure, I haven't validated the IDs and descriptions for correctness

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2025
@joestringer joestringer marked this pull request as draft July 15, 2025 18:04
@joestringer
Copy link
Member

Thanks for the PR! Please address the feedback from the reviewers above. When you've done that, you can use the "Ready for review" button at the bottom of the page to bring this back to the attention of reviewers. I'd suggest also clicking the "re-request review" button at the top right of the page in the "Reviewers" box to be sure the notifications go out.

@nocturo nocturo marked this pull request as ready for review July 16, 2025 07:17
@nocturo nocturo requested a review from qmonnet July 16, 2025 07:18
@nocturo
Copy link
Contributor Author

nocturo commented Jul 16, 2025

Thanks for the suggestions! I've updated the PR with the changes.

qmonnet
qmonnet approved these changes Jul 16, 2025
View reviewed changes
@qmonnet
Copy link
Member

qmonnet commented Jul 16, 2025

/test

@nocturo @qmonnet
docs: Clarify use of routing table IDs in Cilium
5af2c71 
[ Quentin: Squashed commits, fixed typo (IPSec), formatted commit log ]

Fixes: cilium#38531
Signed-off-by: Nemanja Zeljkovic <nocturo@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet
Copy link
Member

qmonnet commented Jul 16, 2025

/test

@qmonnet
Copy link
Member

qmonnet commented Jul 16, 2025

I squashed the commits together (and fixed the case on IPsec).

@qmonnet qmonnet enabled auto-merge July 16, 2025 09:56
@qmonnet qmonnet added this pull request to the merge queue Jul 16, 2025
Merged via the queue into cilium:main with commit ce3805c Jul 16, 2025
65 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@aspsk aspsk aspsk approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium removes existing routes on table 200 on startup
4 participants
@nocturo @joestringer @qmonnet @aspsk