Skip to content

cilium-cli: Standardize build args in dockerfile #40126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

cilium-cli: Standardize build args in dockerfile #40126

merged 1 commit into from
Jun 26, 2025

Conversation

HadrienPatte
Copy link
Member

Standardize the cilium-cli Dockerfile with other dockerfiles by:

  • Making the base image adjustable via a BASE_IMAGE build arg
  • Exposing MODIFIERS as a build-arg, this variable was previously used in the build but it was not possible to give it any value

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
cilium-cli: Standardize build args in dockerfile

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 19, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jun 19, 2025
@HadrienPatte HadrienPatte marked this pull request as ready for review June 19, 2025 11:14
@HadrienPatte HadrienPatte requested a review from a team as a code owner June 19, 2025 11:14
@HadrienPatte HadrienPatte requested a review from derailed June 19, 2025 11:14
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 20, 2025
@HadrienPatte
Copy link
Member Author

/test

derailed
derailed approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HadrienPatte Thank you for this update!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 25, 2025
@HadrienPatte
cilium-cli: Standardize build args in dockerfile
dfe71e9 
Standardize the cilium-cli Dockerfile with other dockerfiles by:
* Making the base image adjustable via a `BASE_IMAGE` build arg
* Exposing `MODIFIERS` as a build-arg, this variable was previously used
  in the build but it was not possible to give it any value

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@HadrienPatte HadrienPatte force-pushed the cilium-cli-build-args branch from 171131a to dfe71e9 Compare June 25, 2025 20:28
@HadrienPatte
Copy link
Member Author

/test

@tklauser tklauser added this pull request to the merge queue Jun 26, 2025
Merged via the queue into cilium:main with commit 172c23b Jun 26, 2025
78 of 79 checks passed
@HadrienPatte HadrienPatte deleted the cilium-cli-build-args branch June 26, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HadrienPatte @derailed @tklauser @joestringer