cilium-cli: clean up log messages #40101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Don't use the %w format verb in log messages, otherwise the error
will be wrapped and will show up as follows in the respective log:
%!w(*errors.errorString=&{some error message})
Use the %s format verb instead to just add the error message to the log
output.
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Remove a stray argument that isn't supposed to be part of the error message and make the message a bit terser by not repeating the feature name. Signed-off-by: Tobias Klauser <tobias@cilium.io>
0c78f3d to
316e23e
Compare
|
/test |
Artyop
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct format verb when logging error messages (
%sinstead of%w) and fix an error message related to requireModeIsNot requirements in feature detection.See commits for details.