Makefile: Require API generation commands to succeed #40199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracing the history all the way back to commit adb32c6 ("docs: Use go-swagger Docker container to generate APIs"), these make targets have always ignore the exit status of the commands to generate the APIs. There's no explanation as to why, and this seems inadvisable since we rely on these commands generating consistent API templates that are used to interact with these APIs. Remove the "-" syntax to require that all such commands succeed. Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
HadrienPatte
approved these changes
Jun 24, 2025
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing the history all the way back to commit adb32c6
("docs: Use go-swagger Docker container to generate APIs"), these make
targets have always ignored the exit status of the commands to generate
the APIs. There's no explanation as to why, and this seems inadvisable
since we rely on these commands generating consistent API templates that
are used to interact with these APIs.
Remove the
-syntax to require that all such commands succeed.