-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: setting policy map pressure metrics threshold #40188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97284fd
to
0cbcfaa
Compare
Oh, this makes total sense. Once v1.18 has cut, we can land this in I had a wild idea: we could theoretically expose a histogram of policy map pressure; given that histograms are intended to expose sampled data. The only problem is that histograms, as implemented in Anyways, no need to take this seriously, just some brain cells this PR ticked. |
On a more relevant note: the documentation CI job is failing. Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one change, otherwise looks good.
Don't you mind if we backport it to 1.17 as well? |
@pasteley seems like you need to update couple of tests: https://github.com/cilium/cilium/actions/runs/15878956787/job/44773797407?pr=40188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some lint issues.
58eb5c6
to
011e15e
Compare
@squeed We need your review here again |
/test |
Ah - unfortunately I lack the power to dismiss @squeed's review - hence when I removed his review request so that this PR can progress, GitHub translated that back to a "Changes Requested". Could a committer dismiss his review (I feel it's adequately addressed) so this PR can progress, once rebased? |
Normally there's some box near the bottom of the page that allows committers to dismiss the review and post a text comment why, but I'm not seeing that UI element on the page right now. Based on the UI state it looks like this is non-blocking however, I can click the 'Merge when ready' button. I will do so and kick off the tests. |
/test |
Signed-off-by: pasteley <ceasebeing@gmail.com>
Head branch was pushed to by a user without write access
/test |
@pasteley Can you rebase your code. The failing check was fixed in the main stream. |
This PR allows you to configure the policy map pressure via Helm values. Previously, it was difficult to determine the baseline map pressure before applying a network policy, which could potentially cause a sudden increase (e.g., from 9% to 100%). With this change, you have better control and visibility over policy map pressure settings