update httpbin example as per istio latest release #40151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
requested changes
Jun 23, 2025
|
/test |
auto-merge was automatically disabled
June 28, 2025 16:24
Head branch was pushed to by a user without write access
85026af to
6c09354
Compare
Update example "httpbin" that originates from Istio project, to its
latest version (as of release 1.26.2).
[ Quentin: Fix missing line break at the end of the file,
add context in commit log. ]
Link: https://github.com/istio/istio/blob/1.26.2/samples/httpbin/httpbin.yaml
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
6c09354 to
89aedfa
Compare
qmonnet
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
You still had a missing line break at the end, see how GitHub displays it:
You did add a new line, but it contained spaces (auto-indentation aligned with the latest YAML item).
I've fixed it for you, and squashed the two commits together. If you need to update this PR, please make sure to pull the changes first.
|
/test |
|
Thank you, @qmonnet, for fixing the indentation. |
|
Yes, I re-triggered and they passed. |
|
just a gentle ping for your review @sayboras |
sayboras
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
update httpbin example as per istio latest release